airdrop.sol

Issue 01

Type

Severity

Location

Status

Best Practice

Informational

AirDrop

Not Resolved

Description

Consider using OpenZepplin AccessControl library for managing rule based access.

Issue 02

Type

Severity

Location

Status

Best Practice

Medium

claim

Resolved

Description

The function call an external contract, exposing itself to potential reentrancy attacks.

The code does not follow check effect interactions pattern.

Recommendation

Add a reentrancy guard or follow check-effect interactions pattern. check-effect interaction pattern is more recommended because reentrancy guard has limitations such us calling other function which has reentrancy guard protection will cause an error. In addition, it's recommended to use check-effects-interact pattern even when using ReentrancyGuard as not all code paths are always protected by it.

Issue 03

Type

Severity

Location

Status

Best Practice

Medium

removeAll

Resolved

Description

The allocators array's size is limitless. Iterating over an unbounded array may cause the transaction to hit the block gas limit.

Recommendation

Add length restrictions on the number of iterations, or if array is not needed consider using mapping [you already have userInfo which track the allocation].`

The team add an upper limit for the allocators array, the team need to make sure that this upper limit is enough.

Last updated